Skip to content

Commit

Permalink
fix: Increase health check to 15 minutes
Browse files Browse the repository at this point in the history
Deployments are currently flaky with the health check failing every so often
due to rate limiting from AWS.

Increase the health check grace period as a temporary solution
to hopefully increase the determinism of deployments.
  • Loading branch information
akash1810 committed Oct 2, 2024
1 parent 7aa7aba commit c1387ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cdk/lib/__snapshots__/prism.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ exports[`The PrismEc2App stack matches the snapshot 1`] = `
"Resources": {
"AutoScalingGroupPrismASG36691601": {
"Properties": {
"HealthCheckGracePeriod": 500,
"HealthCheckGracePeriod": 900,
"HealthCheckType": "ELB",
"LaunchTemplate": {
"LaunchTemplateId": {
Expand Down
2 changes: 1 addition & 1 deletion cdk/lib/prism.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,6 @@ export class Prism extends GuStack {
// Similarly the pattern does not offer support for extending the default ASG grace period via props
const cfnAsg = pattern.autoScalingGroup.node
.defaultChild as CfnAutoScalingGroup;
cfnAsg.healthCheckGracePeriod = 500;
cfnAsg.healthCheckGracePeriod = Duration.minutes(15).toSeconds();
}
}

0 comments on commit c1387ba

Please sign in to comment.