Revert "cap the display and mounting of more than 50 pinboards" #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
revert-323-handle-too-many-open-pinboards
branch
from
ade771e to
0703eb0
Compare
twrichards
force-pushed
the
revert-323-handle-too-many-open-pinboards
branch
from
0703eb0 to
761268e
Compare
twrichards
force-pushed
the
revert-323-handle-too-many-open-pinboards
branch
from
761268e to
01db149
Compare
andrew-nowak
approved these changes
Nov 25, 2024
|
Seen on PROD (merged by @twrichards 3 minutes and 17 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #323 as it didn't solve the problem for the user in question, since it turns out there are three subscriptions per pinboard (
onCreateItem,onMutateItemandonSeenItem) and the user had 34 open pinboards so collectively they exceeded AppSync's 100 subscription (per client) limit.Instead we're going to consolidate into shared subscriptions listening to ALL pinboards and ignore irrelevant events, this should also mean we can stop polling for item counts (and instead fetch the aggregated item counts whenever there's a message on any pinboard), which should (given pinboards limited usage) reduce costs overall - see #325
FYI @paperboyo