-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yarn to latest stable version #307
Conversation
amazing, thank you @mchv - appreciate the detailed sequential PR description - the diff LGTM, I'm checking it out locally now to make sure various scripts involved in running locally all continue to work and will deploy to CODE - expect approval incoming shortly |
looking good so far, but will do some more testing tomorrow - @mchv please feel free to enable auto merge and i'll approve tomorrow morning when all checked - thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again @mchv!
Tested locally (added one small commit) and also deployed to CODE and did a quick test:
looks good, approving now (and given auto-merge also merging)...
What does this change?
This update
yarn
from1.22.17
to the latest stable version4.2.2
.There are a few noteworthy changes:
Adding the range for
react-dom
andreact
dependenciesThe parsing of version dependency since yarn
2.x
is more strict, which means thereact
andreact-dom
alias package
needs an additional range to work (preact issue about it)Removal of
yarn-duplicate
The yarn-duplicate package is not necessary anymore, and has been replaced by the native dedupe command:
Warnings displayed when installing
When executing
yarn install
a few warnings are now displayedThe associated changes do not address them, but with the associated changes it should be easier to update packages to address them (for instance updating
jest
andts-jest
seems sensible and not too difficult)Retrieval of the right version of
yarn
In order to retrieve the right version of yarn, it is now recommended to use corepack, rather than
This is very similar to that change in dotcom-rendering:
Upgrade of node version
However for the right
yarn
version to be picked up, un upgrade to the latest18.xx
node version was needed (see pnpm/pnpm#7724), otherwise yarn version is not found:And
yarn install
fail miserably: