migrate kcl-akka-stream 2.1.0=>4.1.1, kcl 1.8.10=>2.6.0 #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We're using an old version of kcl-akka-stream, which was only ever released to bintray and so was committed directly into the repository when bintray was removed (see #3283). The earliest version of kcl-akka-stream that was released to Maven central is 4.1.1, which depends on kinesis-client-lib 2.x. Upgrade both together, to get onto a version which is both a) on Maven central and b) compatible with scala 2.13.
Note however that kcl-akka-stream is no longer maintained, and a Pekko alternative has not been created (see StreetContxt/kcl-akka-stream#191) which will be an annoyance for a Play 3.0 upgrade. (Technically it isn't required that we remove all usages of Akka to upgrade to Play 3.0, but it'd be very very nice if we could). To be dealt with at a later date.
Note also that this doesn't upgrade the version of the kinesis-client-library used in usage, since that uses rxscala (also no longer maintained) instead of Akka, so doesn't make use of kcl-akka-stream.
How should a reviewer test this change?
kcl-akka-stream is only used by Thrall - so try making some changes to data, or upload images etc. and check that the updates flow through to Thrall, which will then apply those updates onto the Elasticsearch index.
Tested? Documented?