Plugins clearout #4356
Merged
Plugins clearout #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since sbt 1.3.0 this is builtin to sbt, no need for plugin any more
we don't use assembly any more, the last usage was removed over 3 yrs ago so this can go
andrew-nowak
commented
Oct 28, 2024
Comment on lines
+17
to
+21
| // Currently multiple modules depend on scala-java8-compat, some on 0.8.x, 0.9.x and 1.x.y | ||
| // These may be binary incompatible, but force the checker to accept them | ||
| // In the future, check if this override can be removed | ||
| ThisBuild / libraryDependencySchemes += | ||
| "org.scala-lang.modules" %% "scala-java8-compat" % VersionScheme.Always |
There was a problem hiding this comment.
It looks like sbt-coursier was suppressing these warnings; this one popped up when it was removed.
bryophyta
approved these changes
Oct 30, 2024
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
labels
prout-bot
added
Seen-on-auth
Seen-on-leases
Seen-on-usage
Seen-on-kahuna
Seen-on-image-loader
Seen-on-cropper
and removed
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, media-api, kahuna (merged by @andrew-nowak 8 minutes and 47 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-media-api
Seen-on-metadata-editor
Seen-on-thrall
Seen-on-collections
and removed
Pending-on-collections
labels
|
Seen on collections (merged by @andrew-nowak 8 minutes and 52 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove some unused sbt plugins, notably the
sbt-coursierplugin which has some bugs which interferes with sbt's own dependency resolution behaviours.How should a reviewer test this change?
Should be a no-op, with no change in behaviour when deployed
How can success be measured?
Who should look at this?
Tested? Documented?