Add code to check whether a user is allowed to reject all on the CMP #13183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +107 B (+0.01%) Total Size: 885 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
This needs to be worked out in the client for mdapi response
rupertbates
force-pushed
the
allow-reject-all
branch
from
dd4fbf5 to
50025d5
Compare
tomrf1
reviewed
Jan 21, 2025
| @@ -86,12 +93,18 @@ const persistResponse = (userBenefitsResponse: UserBenefits) => { | |||
| } else if (adFreeDataIsPresent() && !forcedAdFreeMode) { | |||
| removeAdFreeCookie(); | |||
| } | |||
| if (userBenefitsResponse.allowRejectAll) { | |||
| setAllowRejectAllCookie(2); | |||
There was a problem hiding this comment.
I'm not sure really, I guess to give a bit of wiggle room past the 24hr refresh period? This is the same as the ad-free cookie which was already in place so I used the same value.
I'm going to do a bit of an investigation into the expiry times we set on these cookies and when we explicitly delete them, so this may change in a future PR
tomrf1
approved these changes
Jan 22, 2025
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @rupertbates 7 minutes and 55 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds code to retrieve and store a user's 'allow reject all' status from either the user-benefits api or the members-data-api (depending on the AB cohort the user is in).
Why?
To enable us to tell which version of the consent management banner to show for signed in users, we need to check whether they are subscribed to either a product which gives them ad-free reading or to Guardian Ad-Lite.
This code does that check and then caches that result in a cookie which is refreshed every 24hrs in the same way as the other user features cookies (ad-free, hide support messaging).