Prevent insertion before secondary level containers on desktop #13173
+148
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
cemms1/adjust-fronts-ad-positions-desktop
branch
from
57e79db to
8bc014b
Compare
|
Size Change: 0 B Total Size: 884 kB ℹ️ View Unchanged
|
cemms1
commented
Jan 20, 2025
Comment on lines
+272
to
+274
| if (collection.containerLevel === 'Secondary') { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is the feature change - preventing insertion before secondary level containers
cemms1
force-pushed
the
cemms1/adjust-fronts-ad-positions-desktop
branch
from
2145e68 to
79aa7c1
Compare
github-actions
bot
removed
the
run_chromatic
deedeeh
approved these changes
Jan 21, 2025
rupertbates
pushed a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds logic to prevent ad insertion before secondary level containers on desktop and adds test for this scenario
Additionally:
AdCandidatetoAdCandidateMobileto more clearly indicate this is only used for the mobile calculations (and ideally we would useDCRCollectionTypedirectly, but not in this PR)DCRCollectionTypeobject in thegetDesktopAdPositionsfunction instead of a partial version of it and adjusts tests to reflect thisWhy?
As part of the work to support the new front layouts, this prevents ads interrupting the logical flow of content on the page.
This is likely to need rework but is a starting point for discussions and analysis
Screenshots
Europe beta screenshots (with secondary level containers)
Nb. The "after" screenshots have not actually loaded most of the ads due to running locally, but do illustrate any changes in ad positioning logic
UK screenshots (without secondary level containers)
Nb. The "after" screenshots have not actually loaded most of the ads due to running locally, but do illustrate any changes in ad positioning logic