-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Quiz Atom Stories #13144
Merged
Merged
Refactor Quiz Atom Stories #13144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `centreColumnDecorator`, so the stories better reflect the layout commonly used in articles. Removed the `splitTheme` decorator, as this is now handled by the "global colour scheme" toolbar item and Chromatic modes. Added Chromatic modes to these stories. Added a `WithResults` story for each variant of the quiz atom. It includes a `play` function to work through the quiz, selecting some answers and revealing/submitting them. This story therefore displays the component in a state that includes the results box, and allows it to be snapshotted like this in Chromatic.
cf14ab7
to
7f2d8e3
Compare
Size Change: 0 B Total Size: 871 kB ℹ️ View Unchanged
|
domlander
approved these changes
Jan 15, 2025
Seen on PROD (merged by @JamieB-gu 8 minutes and 53 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
centreColumnDecorator
, so the stories better reflect the layout commonly used in articles. Removed thesplitTheme
decorator, as this is now handled by the "global colour scheme" toolbar item1 and Chromatic modes2. Added Chromatic modes to these stories.Added a
WithResults
story for each variant of the quiz atom. It includes aplay
function3 to work through the quiz, selecting some answers and revealing/submitting them. This story therefore displays the component in a state that includes the results box, and allows it to be snapshotted like this in Chromatic4.Footnotes
https://storybook.js.org/docs/essentials/toolbars-and-globals ↩
https://www.chromatic.com/docs/modes/ ↩
https://storybook.js.org/docs/essentials/interactions ↩
https://www.chromatic.com/docs/interactions/ ↩