-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove digital subscription cookie #13081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: -61 B (-0.01%) Total Size: 931 kB ℹ️ View Unchanged
|
tomrf1
approved these changes
Jan 6, 2025
Seen on PROD (merged by @rupertbates 8 minutes and 44 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR removes the digital subscription user features cookie.
Why?
Previously we used this cookie to store information about whether a user had a digital subscription and then made the decision about whether they were entitled to ad-free reading as a result of that. However this is problematic because there are other products which give ad-free reading as a benefit and we don't want to duplicate this logic for each of them.
In future we want to just give ad-free reading to those users who already have the ad-free cookie (which is set by support-frontend post purchase), or when the response from the user-benefits api tells us that they are entitled to ad-free reading.
Currently we are not using the user-benefits api in DCR so this PR still looks at the
digitalPack
flag in the members-data-api response but then persists the user's entitlement in the ad-free cookie rather than the digital subscription one.Screenshots