Use card headline fonts for card byline #12873
Open
+176
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dotcom-rendering
and removed
run_chromatic
|
Size Change: -211 B (-0.02%) Total Size: 957 kB
ℹ️ View Unchanged
|
abeddow91
commented
Nov 20, 2024
Comment on lines
66
to
89
| const sublinkStyles = css` | ||
| display: block; | ||
| /* See: https://css-tricks.com/nested-links/ */ | ||
| ${getZIndex('card-nested-link')} | ||
| /* The following styles turn off those provided by Link */ | ||
| color: inherit; | ||
| text-decoration: none; | ||
| /* stylelint-disable-next-line property-disallowed-list */ | ||
| font-family: inherit; | ||
| font-size: inherit; | ||
| line-height: inherit; | ||
|
|
||
| const textSansSize = { | ||
| xxxlarge: textSans20, | ||
| xxlarge: textSans20, | ||
| xlarge: textSans20, | ||
| large: textSans20, | ||
| medium: textSans20, | ||
| small: textSans20, | ||
| xsmall: textSans20, | ||
| xxsmall: textSans17, | ||
| xxxsmall: textSans15, | ||
| tiny: textSans12, | ||
| }; | ||
| /* This css is used to remove any underline from the kicker but still | ||
| * have it applied to the headline when the kicker is hovered */ | ||
| :hover { | ||
| color: inherit; | ||
| text-decoration: none; | ||
| .show-underline { | ||
| text-decoration: underline; | ||
| text-underline-offset: auto; | ||
| text-underline-position: auto; | ||
| } | ||
| } | ||
| `; |
There was a problem hiding this comment.
this has been moved higher up the file, it is not a new addition
abeddow91
commented
Nov 20, 2024
| return 'medium'; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
we no longer need to convert the sizes here as we pass font styles directly to byline
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
abeddow91
force-pushed
the
ab/card-byline
branch
from
648bb70
to
3a2ae43
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
approved these changes
Nov 21, 2024
abeddow91
force-pushed
the
ab/byline-none-italics
branch
from
7d7e102
to
777525c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Allows the byline to use the same font styles as the headline by passing through the font styles as a prop.
It also extends the font offering in card headline to include headline light as this is used by opinion cards. A card is considered an opinion card if it matches one of the following format criteria:
It also refactors the card headline component with the intent of tightening the types to make it easier to select the correct font family and size.
Why?
Recent redesigns determine that card bylines should inherit the card headline styles (except colour). As the byline is not always a child of the headline, we cannot simply inherit the styles so we pass them through instead.
Screenshots