-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Source v7.x #12145
Update to Source v7.x #12145
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
i believe @jamesmockett will be considering the errors 😺 |
Size Change: +3.88 kB (+0.44%) Total Size: 881 kB
ℹ️ View Unchanged
|
If its useful, @cemms1 did some work to bump source to v6 not too long ago @jamesmockett @sndrs #12063 which might help with error fixes |
Thanks @abeddow91 🙏 This PR branches off of Charlotte's work, so includes the fixes / updates she's already made. v7 introduces a bunch of new errors due to the removal of the typography API. I'll try and take a look at those later today and catch up with Charlotte. |
This PR should merge into Charlotte's PR too, in effect adding v7 stuff to her existing PR |
b6c466e
to
5c94ad8
Compare
I've updated #12063 with main now. Shall we include these changes all together in the original PR or should we merge #12063 separately first followed by this one? I wonder if we should keep them separate rather than bundling all updates into one |
It might be simpler to update separately. I suppose we could update this branch from #12063 once you're happy with it and see how many more diffs we get in Chromatic? |
The original PR has some strange chromatic diffs actually, so I'm going to break it down into smaller changes to make it easier to get through. PRs incoming... |
This has been superseded by #12342 |
What does this change?
includes bump to v7 of source and dev kitchen for #12063
Why?
to keep them up to date.
v7 also includes performance benefits to users and a reduced bundle size.