Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 0% test for spacefinder inline1 changes #12143

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add 0% test for spacefinder inline1 changes #12143

merged 1 commit into from
Aug 14, 2024

Conversation

emma-imber
Copy link
Contributor

What does this change?

Adds a 0% test for some changes to Spacefinder's rules for inline1 ads. 0% for now, as we're waiting on sample sizes to be confirmed, but still useful to have the 0% test so that we can check the new ad rules look good on a range of articles.

@emma-imber emma-imber requested a review from a team as a code owner August 14, 2024 14:37
@github-actions GitHub Actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@emma-imber emma-imber added run_chromatic Runs chromatic when label is applied Commercial 💰 labels Aug 14, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 14, 2024
@github-actions GitHub Actions
Copy link

Size Change: +64 B (+0.01%)

Total Size: 905 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1000.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/1026.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1090.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/1140.client.web.********************.js 6.4 kB 0 B
dotcom-rendering/dist/121.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/1295.client.web.********************.js 524 B 0 B
dotcom-rendering/dist/1391.client.web.********************.js 725 B 0 B
dotcom-rendering/dist/1476.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1644.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/1667.client.web.********************.js 918 B 0 B
dotcom-rendering/dist/1940.client.web.********************.js 22.7 kB 0 B
dotcom-rendering/dist/2193.client.web.********************.js 529 B 0 B
dotcom-rendering/dist/2280.client.web.********************.js 7.34 kB 0 B
dotcom-rendering/dist/2310.client.web.********************.js 880 B 0 B
dotcom-rendering/dist/2419.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/267.client.web.********************.js 917 B 0 B
dotcom-rendering/dist/281.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/3109.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3115.client.web.********************.js 2.99 kB 0 B
dotcom-rendering/dist/3270.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/3304.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/3467.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/3650.client.web.********************.js 4.3 kB 0 B
dotcom-rendering/dist/3711.client.web.********************.js 5.49 kB 0 B
dotcom-rendering/dist/3727.client.web.********************.js 12.5 kB 0 B
dotcom-rendering/dist/3732.client.web.********************.js 618 B 0 B
dotcom-rendering/dist/3769.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/4015.client.web.********************.js 5.83 kB 0 B
dotcom-rendering/dist/4243.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/4248.client.web.********************.js 9.19 kB 0 B
dotcom-rendering/dist/4282.client.web.********************.js 685 B 0 B
dotcom-rendering/dist/447.client.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/4472.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/4628.client.web.********************.js 654 B 0 B
dotcom-rendering/dist/4642.client.web.********************.js 2.52 kB 0 B
dotcom-rendering/dist/4692.client.web.********************.js 4.39 kB 0 B
dotcom-rendering/dist/4741.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/4788.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/4895.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/4941.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/5221.client.web.********************.js 9.8 kB 0 B
dotcom-rendering/dist/5301.client.web.********************.js 3.1 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/5636.client.web.********************.js 3.47 kB 0 B
dotcom-rendering/dist/5658.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/5757.client.web.********************.js 931 B 0 B
dotcom-rendering/dist/5783.client.web.********************.js 3.74 kB 0 B
dotcom-rendering/dist/5880.client.web.********************.js 828 B 0 B
dotcom-rendering/dist/6044.client.web.********************.js 726 B 0 B
dotcom-rendering/dist/6071.client.web.********************.js 577 B 0 B
dotcom-rendering/dist/6135.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/6150.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/6182.client.web.********************.js 2.31 kB 0 B
dotcom-rendering/dist/6254.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/6278.client.web.********************.js 13.8 kB 0 B
dotcom-rendering/dist/6457.client.web.********************.js 19.8 kB 0 B
dotcom-rendering/dist/6502.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/6505.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/6596.client.web.********************.js 4.06 kB 0 B
dotcom-rendering/dist/6598.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/6637.client.web.********************.js 6.21 kB 0 B
dotcom-rendering/dist/6638.client.web.********************.js 907 B 0 B
dotcom-rendering/dist/6777.client.web.********************.js 6.51 kB 0 B
dotcom-rendering/dist/678.client.web.********************.js 804 B 0 B
dotcom-rendering/dist/6881.client.web.********************.js 4.68 kB 0 B
dotcom-rendering/dist/70.client.web.********************.js 2.67 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7148.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/7213.client.web.********************.js 10.7 kB 0 B
dotcom-rendering/dist/7673.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/7689.client.web.********************.js 4.21 kB 0 B
dotcom-rendering/dist/7691.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/7774.client.web.********************.js 4.15 kB 0 B
dotcom-rendering/dist/7788.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/7806.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/7815.client.web.********************.js 4.91 kB 0 B
dotcom-rendering/dist/786.client.web.********************.js 4.5 kB 0 B
dotcom-rendering/dist/7911.client.web.********************.js 1.84 kB 0 B
dotcom-rendering/dist/8061.client.web.********************.js 3.1 kB 0 B
dotcom-rendering/dist/83.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/8406.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/8504.client.web.********************.js 827 B 0 B
dotcom-rendering/dist/8525.client.web.********************.js 2.26 kB 0 B
dotcom-rendering/dist/8536.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8626.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/8654.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/8697.client.web.********************.js 956 B 0 B
dotcom-rendering/dist/8826.client.web.********************.js 4.4 kB 0 B
dotcom-rendering/dist/8833.client.web.********************.js 829 B 0 B
dotcom-rendering/dist/888.client.web.********************.js 43.1 kB 0 B
dotcom-rendering/dist/9155.client.web.********************.js 3.22 kB 0 B
dotcom-rendering/dist/9184.client.web.********************.js 493 B 0 B
dotcom-rendering/dist/9205.client.web.********************.js 3.21 kB 0 B
dotcom-rendering/dist/9210.client.web.********************.js 4.3 kB 0 B
dotcom-rendering/dist/9215.client.web.********************.js 3.06 kB 0 B
dotcom-rendering/dist/9222.client.web.********************.js 155 B 0 B
dotcom-rendering/dist/9431.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/9435.client.web.********************.js 4.61 kB 0 B
dotcom-rendering/dist/9493.client.web.********************.js 785 B 0 B
dotcom-rendering/dist/9557.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/9559.client.web.********************.js 509 B 0 B
dotcom-rendering/dist/9570.client.web.********************.js 441 B 0 B
dotcom-rendering/dist/9721.client.web.********************.js 717 B 0 B
dotcom-rendering/dist/9835.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/9858.client.web.********************.js 6.41 kB 0 B
dotcom-rendering/dist/9899.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/Accessibility-importable.client.web.********************.js 6.3 kB 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.85 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.55 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.62 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.04 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.47 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.33 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 3.05 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 37.2 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.97 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.7 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 7.39 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 6.01 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 4.5 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 538 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.81 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 1.22 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.74 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.64 kB 0 B
dotcom-rendering/dist/Dropdown-importable.client.web.********************.js 1.73 kB 0 B
dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js 6.51 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 3.74 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.02 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.44 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 5.21 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 623 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 3.39 kB 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 347 B 0 B
dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js 3.74 kB 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.8 kB 0 B
dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js 5.38 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 6.03 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 12.1 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 7.99 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.71 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 16.7 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 11 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 10.2 kB 0 B
dotcom-rendering/dist/HighlightsContainer-importable.client.web.********************.js 4.7 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 46.1 kB -2 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.29 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.33 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.72 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 6.75 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.74 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.51 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 1.53 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 436 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 8.16 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.79 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.94 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 7.83 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.46 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.73 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 5.72 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 8.35 kB 0 B
dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js 4.7 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 5.82 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 3.04 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 469 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.97 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 2.51 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 5.21 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 5.1 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.16 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 767 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.69 kB +66 B (+1.82%)
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 486 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.53 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 1.4 kB 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 3.92 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.15 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.31 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 4.15 kB 0 B
dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js 7.53 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 3.37 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 6.6 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 3.23 kB 0 B
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 7.96 kB 0 B
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.75 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.47 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.13 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 7.04 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.94 kB 0 B

compressed-size-action

@emma-imber emma-imber merged commit db64f62 into main Aug 14, 2024
37 checks passed
@emma-imber emma-imber deleted the ei/add-inline1-spacefinder-test branch August 14, 2024 15:10
@prout-bot
Copy link

Seen on PROD (merged by @emma-imber 9 minutes and 53 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakeii Jakeii Jakeii approved these changes

Assignees
No one assigned
Labels
Commercial 💰 dotcom-rendering Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emma-imber @prout-bot @Jakeii