-
Notifications
You must be signed in to change notification settings - Fork 30
Titlepiece logo click area #12133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Titlepiece logo click area #12133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
37fe2d1
to
fe5d738
Compare
Size Change: +12 B (0%) Total Size: 905 kB ℹ️ View Unchanged
|
Georges-GNM
approved these changes
Aug 14, 2024
Seen on PROD (merged by @abeddow91 9 minutes and 53 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
It reduces the width of the pillars so that they do not overlap with the logo and lets click events pass through the spare space to the logo.
It also changes the logo to have a flex display which allows the anchors focus state to fill the whole logo on keyboard navigation for accessibility.
Screenshots
before
Screen.Recording.2024-08-13.at.16.41.49.mov
after
Screen.Recording.2024-08-13.at.16.42.39.mov