Changes for Epic choice cards v2 - single contributions test #12042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +788 B (+0.09%) Total Size: 899 kB
ℹ️ View Unchanged
|
| }: ThreeTierChoiceCardsProps) => { | ||
| const currencySymbol = getLocalCurrencySymbol(countryCode); | ||
| const countryGroupId = countryCodeToCountryGroupId(countryCode); | ||
|
|
||
| const Choices = getChoiceCardData(variantOfChoiceCard) as ChoiceInfo[]; |
There was a problem hiding this comment.
You can remove the as here and add the types to the getChoiceCardData function as its return type
| @@ -186,6 +188,7 @@ export const ContributionsEpicButtons = ({ | |||
| const getChoiceCardCta = (cta: Cta): Cta => { | |||
| if ( | |||
| showThreeTierChoiceCards && | |||
| !variantOfChoiceCard && | |||
There was a problem hiding this comment.
is this if statement not redundant now? We pass the prop variantOfChoiceCard in Live blog and normal Epic so both cases will fall into the next if statement
| @@ -95,6 +100,7 @@ type ChoiceInfo = { | |||
| benefitsLabel?: string; | |||
| benefits: string[]; | |||
| recommended: boolean; | |||
| url: string; | |||
There was a problem hiding this comment.
I can't see the URL being used?
andrewHEguardian
approved these changes
Aug 1, 2024
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Seen on PROD (merged by @LAKSHMIRPILLAI 8 minutes and 40 seconds ago) Please check your changes! |
tomrf1
reviewed
Aug 8, 2024
| return { | ||
| text: cta.text, | ||
| baseUrl: addChoiceCardsParams( | ||
| cta.baseUrl, | ||
| 'MONTHLY', // only doing monthly in the first test | ||
| 'https://support.theguardian.com/uk/contribute/checkout', |
There was a problem hiding this comment.
should be https://support.theguardian.com/contribute/checkout - without the region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Epic choice cards v2 - single contributions test
Why?
The first choice card redesign test provided a fantastic result for non-US regions. However, we need to optimise this functionality for the US as well and will re-try the design but with an emphasis on single contributions too.
V1: By anchoring a SC at the lowest price point and directing the user to the second step of the checkout, we can capture better S+ acquisitions without a drop off in SC.
V2: By removing the recommended pill, we can empower our users to select a flexible offering that best suits their needs, thus driving extra revenue per impression.
Trello card
Figma file
Screenshots
V1 of New Choice cards
V2 of New Choice cards
Clicking on Support just once from £1 , takes user to
Clicking on Support £4/month, takes user to
Clicking on Support £12/month, takes user to