Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove snyk #10032

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Remove snyk #10032

merged 2 commits into from
Jan 2, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Jan 2, 2024 •
edited
Loading

What does this change?

removes refs to snyk from the repo

Why?

#9476 moved the project to pnpm, but snyk doesn't support pnpm.

After talking it through with the @guardian/devx-security team, it was agreed that dependabot's own security scanning was sufficient for pnpm-managed projects.

Since this repo is such a project, this removes the now-redundant snyk stuff.

@sndrs sndrs self-assigned this Jan 2, 2024
@sndrs sndrs added this to the 👋 Yarn v1 milestone Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

Deploy build 45211 of dotcom:rendering to CODE

All deployment options

From guardian/actions-riff-raff.

Base automatically changed from sndrs/remove-doctoc to main January 2, 2024 15:29
@sndrs sndrs force-pushed the sndrs/remove-snyk branch from 972ef45 to 784a1b6 Compare January 2, 2024 15:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 742 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1028.web.********************.js 783 B
dotcom-rendering/dist/1285.web.********************.js 921 B
dotcom-rendering/dist/1309.web.********************.js 637 B
dotcom-rendering/dist/1378.web.********************.js 503 B
dotcom-rendering/dist/1596.web.********************.js 3.69 kB
dotcom-rendering/dist/1623.web.********************.js 847 B
dotcom-rendering/dist/1712.web.********************.js 3.16 kB
dotcom-rendering/dist/1787.web.********************.js 6.4 kB
dotcom-rendering/dist/192.web.********************.js 4.23 kB
dotcom-rendering/dist/2030.web.********************.js 491 B
dotcom-rendering/dist/2118.web.********************.js 775 B
dotcom-rendering/dist/2138.web.********************.js 2.59 kB
dotcom-rendering/dist/239.web.********************.js 2.49 kB
dotcom-rendering/dist/2406.web.********************.js 3.38 kB
dotcom-rendering/dist/2416.web.********************.js 775 B
dotcom-rendering/dist/2499.web.********************.js 3.51 kB
dotcom-rendering/dist/2710.web.********************.js 999 B
dotcom-rendering/dist/273.web.********************.js 5.75 kB
dotcom-rendering/dist/276.web.********************.js 5.18 kB
dotcom-rendering/dist/2834.web.********************.js 2.51 kB
dotcom-rendering/dist/2903.web.********************.js 884 B
dotcom-rendering/dist/2927.web.********************.js 5.1 kB
dotcom-rendering/dist/2993.web.********************.js 636 B
dotcom-rendering/dist/3551.web.********************.js 3.33 kB
dotcom-rendering/dist/3678.web.********************.js 403 B
dotcom-rendering/dist/3743.web.********************.js 900 B
dotcom-rendering/dist/3999.web.********************.js 744 B
dotcom-rendering/dist/4355.web.********************.js 710 B
dotcom-rendering/dist/4567.web.********************.js 819 B
dotcom-rendering/dist/4645.web.********************.js 40.3 kB
dotcom-rendering/dist/4946.web.********************.js 718 B
dotcom-rendering/dist/4950.web.********************.js 664 B
dotcom-rendering/dist/5055.web.********************.js 2.91 kB
dotcom-rendering/dist/5091.web.********************.js 519 B
dotcom-rendering/dist/5107.web.********************.js 5.03 kB
dotcom-rendering/dist/512.web.********************.js 819 B
dotcom-rendering/dist/5165.web.********************.js 742 B
dotcom-rendering/dist/5209.web.********************.js 525 B
dotcom-rendering/dist/5288.web.********************.js 3.27 kB
dotcom-rendering/dist/5289.web.********************.js 2.47 kB
dotcom-rendering/dist/533.web.********************.js 916 B
dotcom-rendering/dist/5353.web.********************.js 8.9 kB
dotcom-rendering/dist/5840.web.********************.js 915 B
dotcom-rendering/dist/585.web.********************.js 2.85 kB
dotcom-rendering/dist/5927.web.********************.js 819 B
dotcom-rendering/dist/5996.web.********************.js 797 B
dotcom-rendering/dist/6302.web.********************.js 3.6 kB
dotcom-rendering/dist/651.web.********************.js 847 B
dotcom-rendering/dist/6541.web.********************.js 909 B
dotcom-rendering/dist/6602.web.********************.js 13.2 kB
dotcom-rendering/dist/6643.web.********************.js 950 B
dotcom-rendering/dist/6754.web.********************.js 9.99 kB
dotcom-rendering/dist/6763.web.********************.js 589 B
dotcom-rendering/dist/6784.web.********************.js 739 B
dotcom-rendering/dist/6802.web.********************.js 990 B
dotcom-rendering/dist/7002.web.********************.js 871 B
dotcom-rendering/dist/7444.web.********************.js 781 B
dotcom-rendering/dist/7726.web.********************.js 955 B
dotcom-rendering/dist/7860.web.********************.js 675 B
dotcom-rendering/dist/7869.web.********************.js 3.49 kB
dotcom-rendering/dist/7875.web.********************.js 3.79 kB
dotcom-rendering/dist/7973.web.********************.js 3.79 kB
dotcom-rendering/dist/8060.web.********************.js 578 B
dotcom-rendering/dist/8288.web.********************.js 23 kB
dotcom-rendering/dist/8320.web.********************.js 796 B
dotcom-rendering/dist/8395.web.********************.js 5.5 kB
dotcom-rendering/dist/8413.web.********************.js 1.84 kB
dotcom-rendering/dist/843.web.********************.js 613 B
dotcom-rendering/dist/8514.web.********************.js 3.14 kB
dotcom-rendering/dist/8562.web.********************.js 998 B
dotcom-rendering/dist/8585.web.********************.js 2.75 kB
dotcom-rendering/dist/8790.web.********************.js 2.98 kB
dotcom-rendering/dist/8798.web.********************.js 16.2 kB
dotcom-rendering/dist/8859.web.********************.js 3.08 kB
dotcom-rendering/dist/8965.web.********************.js 8.12 kB
dotcom-rendering/dist/8995.web.********************.js 782 B
dotcom-rendering/dist/9008.web.********************.js 4.71 kB
dotcom-rendering/dist/9033.web.********************.js 883 B
dotcom-rendering/dist/9045.web.********************.js 715 B
dotcom-rendering/dist/9157.web.********************.js 5.75 kB
dotcom-rendering/dist/9495.web.********************.js 5.22 kB
dotcom-rendering/dist/9636.web.********************.js 5.2 kB
dotcom-rendering/dist/9721.web.********************.js 646 B
dotcom-rendering/dist/AdPortals-importable.web.********************.js 3.63 kB
dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js 416 B
dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js 8.18 kB
dotcom-rendering/dist/AppsEpic-importable.web.********************.js 4.02 kB
dotcom-rendering/dist/AppsFooter-importable.web.********************.js 3.56 kB
dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js 2.94 kB
dotcom-rendering/dist/AppsLightboxImageStore-importable.web.********************.js 2.41 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js 3.58 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js 4.61 kB
dotcom-rendering/dist/Branding-importable.web.********************.js 2.52 kB
dotcom-rendering/dist/braze-web-sdk-core.web.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js 5.26 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js 6.79 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js 5.77 kB
dotcom-rendering/dist/CardCommentCount-importable.web.********************.js 4.39 kB
dotcom-rendering/dist/Carousel-importable.web.********************.js 7.78 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js 5.66 kB
dotcom-rendering/dist/ChartAtom-importable.web.********************.js 537 B
dotcom-rendering/dist/CommentCount-importable.web.********************.js 3.21 kB
dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js 23.4 kB
dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js 3.74 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js 3.57 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js 4.1 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js 1.96 kB
dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js 2.51 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js 3.31 kB
dotcom-rendering/dist/FocusStyles-importable.web.********************.js 606 B
dotcom-rendering/dist/FollowWrapper-importable.web.********************.js 3.08 kB
dotcom-rendering/dist/FooterLabel-importable.web.********************.js 337 B
dotcom-rendering/dist/frameworks.web.********************.js 20.7 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js 3.73 kB
dotcom-rendering/dist/GetMatchNav-importable.web.********************.js 9.63 kB
dotcom-rendering/dist/GetMatchStats-importable.web.********************.js 1.74 kB
dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js 2.75 kB
dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js 14.7 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js 9.3 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js 780 B
dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js 10.8 kB
dotcom-rendering/dist/index.web.********************.js 45.9 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js 3.66 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js 6.07 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js 4.63 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js 3.88 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js 4.13 kB
dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js 3.52 kB
dotcom-rendering/dist/LatestLinks-importable.web.********************.js 1.21 kB
dotcom-rendering/dist/LightboxHash-importable.web.********************.js 429 B
dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js 4.4 kB
dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js 3.93 kB
dotcom-rendering/dist/Liveness-importable.web.********************.js 4.91 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js 5.04 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js 5.62 kB
dotcom-rendering/dist/Metrics-importable.web.********************.js 2.29 kB
dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js 5.2 kB
dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js 3.35 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js 3.87 kB
dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js 4.16 kB
dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js 3.66 kB
dotcom-rendering/dist/ProfileAtom-importable.web.********************.js 540 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js 799 B
dotcom-rendering/dist/PulsingDot-importable.web.********************.js 746 B
dotcom-rendering/dist/QandaAtom-importable.web.********************.js 536 B
dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js 465 B
dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js 2.37 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js 6.23 kB
dotcom-rendering/dist/RelativeTime-importable.web.********************.js 1.92 kB
dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js 6.18 kB
dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js 4.92 kB
dotcom-rendering/dist/SendAMessage-importable.web.********************.js 4.39 kB
dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js 2.1 kB
dotcom-rendering/dist/sentry.web.********************.js 768 B
dotcom-rendering/dist/SetABTests-importable.web.********************.js 3.5 kB
dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js 481 B
dotcom-rendering/dist/shimport.web.********************.js 2.78 kB
dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js 642 B
dotcom-rendering/dist/ShowMore-importable.web.********************.js 5.68 kB
dotcom-rendering/dist/SignInGateMain.web.********************.js 3.89 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js 4.98 kB
dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js 5.55 kB
dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js 6.77 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js 5.47 kB
dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js 5.54 kB
dotcom-rendering/dist/SubNav-importable.web.********************.js 2.38 kB
dotcom-rendering/dist/SupportTheG-importable.web.********************.js 6.35 kB
dotcom-rendering/dist/TableOfContents-importable.web.********************.js 3.09 kB
dotcom-rendering/dist/TimelineAtom-importable.web.********************.js 1.24 kB
dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js 1.02 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js 3.67 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js 5.64 kB
dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js 3.5 kB
dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js 5.42 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js 4 kB

compressed-size-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

Deploy build 30367 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@sndrs sndrs marked this pull request as ready for review January 2, 2024 17:13
@sndrs sndrs requested a review from a team as a code owner January 2, 2024 17:13
@sndrs sndrs requested review from tjsilver and NovemberTang January 2, 2024 17:15
cemms1
cemms1 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A worthwhile tidy up even if we didn't move to pnpm! Thanks!

dotcom-rendering/README.md
Comment on lines +152 to +154
#### `pnpm audit`

To check for vulnerabilities in development, you can run `pnpm audit`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh nice

@sndrs sndrs merged commit 0cc8b75 into main Jan 2, 2024
32 checks passed
@sndrs sndrs deleted the sndrs/remove-snyk branch January 2, 2024 17:38
@prout-bot
Copy link

Seen on PROD (merged by @sndrs 12 minutes and 19 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemms1 cemms1 cemms1 approved these changes

@NovemberTang NovemberTang NovemberTang approved these changes

@tjsilver tjsilver Awaiting requested review from tjsilver

Assignees

@sndrs sndrs

Labels
DevX dotcom-rendering Seen-on-PROD
Projects
None yet
Milestone
👋 Yarn v1
Development

Successfully merging this pull request may close these issues.
4 participants
@sndrs @prout-bot @cemms1 @NovemberTang