Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode in DCAR for Dotcom and Apps #8729

Closed
Tracked by #8817 ...
JamieB-gu opened this issue Sep 1, 2023 · 0 comments
Closed
Tracked by #8817 ...

Dark Mode in DCAR for Dotcom and Apps #8729

JamieB-gu opened this issue Sep 1, 2023 · 0 comments

Comments

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Sep 1, 2023

The apps support dark mode, so in order for DCR to render articles in the apps it must support dark mode too. Dotcom and Editions do not support dark mode, so DCR components have to include dark mode conditionally, depending on the target currently being rendered for.

How?

We completed a spike on this in #7071 and came up with a proposal for how this might work in #7766. This can be built upon to complete this issue and implement dark mode.

Outstanding Questions

We still need to figure out how to handle "sub-palettes" on articles. While the main content of an article has a single ArticleFormat from which a palette can be derived, the cards in onward content do not and can have a range of different palettes. More information in:

@JamieB-gu JamieB-gu added the Epic label Sep 4, 2023
@jamesgorrie jamesgorrie changed the title Dark Mode [Epic]: DCR for Apps - Dark Mode Sep 5, 2023
@abeddow91 abeddow91 assigned abeddow91 and unassigned abeddow91 Sep 20, 2023
@JamieB-gu JamieB-gu removed the Epic label Oct 16, 2024
@JamieB-gu JamieB-gu changed the title [Epic]: DCR for Apps - Dark Mode Dark Mode in DCAR for Dotcom and Apps Oct 21, 2024
@JamieB-gu JamieB-gu self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants