Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: dark mode support #7071

Closed
georgeblahblah opened this issue Jan 30, 2023 · 2 comments
Closed

Spike: dark mode support #7071

georgeblahblah opened this issue Jan 30, 2023 · 2 comments
Assignees
@JamieB-gu
Milestone
[P6] Have a DCR a...

Comments

@georgeblahblah
Copy link
Contributor

georgeblahblah commented Jan 30, 2023 •
edited by rhiannareechaye
Loading

#7734
@georgeblahblah georgeblahblah converted this from a draft issue Jan 30, 2023
@rhiannareechaye rhiannareechaye moved this from Todo (next priority) to Backlog (in priority) in WebX team (do not use) Mar 23, 2023
@rhiannareechaye rhiannareechaye added this to the [P3] DCAR: Support Dark Mode milestone Mar 30, 2023
@rhiannareechaye
Copy link
Contributor

@ajbreuer I don't think there's much that needs to be done here from a design perspective, but @georgeblahblah please could you make sure you look Alex in when you look at this ticket in case there is

@JamieB-gu JamieB-gu removed the DCAR label Apr 3, 2023
@Georges-GNM Georges-GNM mentioned this issue May 15, 2023
Closed
@rhiannareechaye rhiannareechaye modified the milestones: [P3] DCAR: Support Dark Mode, [P5] Get DCAR out to Prod users, [P4] Get DCAR out to Beta users, [P4] Get DCAR out to Beta users (1st milestone) May 23, 2023
@rhiannareechaye rhiannareechaye modified the milestones: [P4] Get DCAR out to Beta users (1st milestone), [P7] DCAR: Visual changes (post Beta), [P6] Have a DCR article working in Prod Jul 27, 2023
@JamieB-gu
Copy link
Contributor

This issue was to conduct a spike, which I think we completed with the work in #7734 mentioned above, and finally the proposal in #7766. I'm going to close this and use #8729 to track the actual work to implement dark mode.

@JamieB-gu JamieB-gu mentioned this issue Sep 1, 2023
Closed
This was referenced Oct 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieB-gu JamieB-gu

Labels
None yet
Projects
No open projects
WebX team (do not use)
Status: Backlog
Milestone
[P6] Have a DCR article working in Prod
Development

Successfully merging a pull request may close this issue.

RFC: Apps Dark Mode Support guardian/dotcom-rendering
3 participants
@georgeblahblah @JamieB-gu @rhiannareechaye