Revert "Revert "Upgrade Yarn to v4""

This reverts commit 8661a2c.

.github/workflows/amp.yml

@@ -25,7 +25,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Validate AMP
         run: make ampValidation

.github/workflows/ar-chromatic.yml

@@ -36,7 +36,7 @@ jobs:
           cache: 'yarn'
 
       # Root yarn installs all workspaces (root, dotcom)
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Chromatic - Apps Rendering
         env:

.github/workflows/ar-ci.yml

@@ -33,7 +33,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          yarn --silent --frozen-lockfile
+          yarn --silent --immutable
 
       # Execute some tasks from the `apps-rendering/package.json` file, using `yarn`
       - name: Build and package

.github/workflows/ar-nodejs.yml

@@ -25,7 +25,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn --frozen-lockfile
+      - run: yarn --immutable
 
       - name: lint
         run: yarn lint

.github/workflows/ar-pr-deployment.yml

@@ -23,7 +23,7 @@ jobs:
           cache: 'yarn'
 
       - name: install
-        run: yarn --frozen-lockfile
+        run: yarn --immutable
         working-directory: apps-rendering
       - name: run
         working-directory: apps-rendering

.github/workflows/build-check.yml

@@ -20,7 +20,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Generate production build
         run: make build

.github/workflows/bundle-analyser.yml

@@ -19,7 +19,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Generate production build
         run: make build

.github/workflows/cypress.yml

@@ -29,7 +29,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Cypress run
         uses: cypress-io/github-action@v6

.github/workflows/dcr-chromatic.yml

@@ -36,7 +36,7 @@ jobs:
           cache: 'yarn'
 
       # Root yarn installs all workspaces (root, dotcom)
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Chromatic - DCR
         env:

.github/workflows/jest.yml

@@ -12,7 +12,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Run Jest
         run: CI=true yarn test

.github/workflows/lighthouse.yml

@@ -21,7 +21,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
       # Make sure we install dependencies in the root directory
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
       - run: make build
         working-directory: dotcom-rendering
       - name: Install and run Lighthouse CI

.github/workflows/playwright.yml

@@ -29,7 +29,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Install Playwright Browsers
         run: yarn playwright install --with-deps chromium

.github/workflows/pr-deployment.yml

@@ -23,7 +23,7 @@ jobs:
           node-version-file: .nvmrc
           cache: 'yarn'
       # Make sure we install dependencies in the root directory
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
       - run: make build
         working-directory: dotcom-rendering
       - name: Boot server and run ngrok

.github/workflows/prettier.yml

@@ -12,7 +12,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Prettier check
         run: yarn prettier:check

.github/workflows/schema-check.yml

@@ -20,7 +20,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Run check-schema script
         run: make check-schema

.github/workflows/stories-check.yml

@@ -20,7 +20,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Run check-stories script
         run: make check-stories

.github/workflows/typescript.yml

@@ -17,7 +17,7 @@ jobs:
           node-version-file: .nvmrc
           cache: 'yarn'
 
-      - run: yarn install --frozen-lockfile
+      - run: yarn install --immutable
 
       - name: Check typescript
         run: yarn tsc

.gitignore

@@ -11,9 +11,14 @@ yarn-error.log*
 
 # Dependency directories
 node_modules
+.yarn/*
 
-# Yarn Integrity file
-.yarn-integrity
+# Things yarn might create that we'd want to check in
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
 
 # IDE files
 .idea

.husky/post-merge

@@ -11,7 +11,7 @@ changedNode="$(echo "$changedFiles" | { grep '.nvmrc' || :; })"
 if [[ ! -z $changedLock ]]
 then
 	echo "${RED}This application has new dependencies. Running 'yarn'... ${ENDCOLOR}"
-	yarn --frozen-lockfile
+	yarn --immutable
 fi
 
 if [[ ! -z $changedNode ]]

.yarnrc.yml

@@ -0,0 +1,5 @@
+defaultSemverRangePrefix: ''
+
+nmHoistingLimits: workspaces
+
+nodeLinker: node-modules

apps-rendering/src/client/article.ts

@@ -1,3 +1,5 @@
+/* eslint-disable react/no-deprecated -- currently still working in 17 mode */
+
 // ----- Imports ----- //
 
 import type { Client as NotificationsClient } from '@guardian/bridget/Notifications';

apps-rendering/src/client/callouts.ts

@@ -1,3 +1,5 @@
+/* eslint-disable react/no-deprecated -- currently still working in 17 mode */
+
 import type { Contact } from '@guardian/apps-rendering-api-models/contact';
 import type { FormField } from '@guardian/apps-rendering-api-models/formField';
 import type { FormOption } from '@guardian/apps-rendering-api-models/formOption';

apps-rendering/src/client/editions.ts

@@ -1,3 +1,5 @@
+/* eslint-disable react/no-deprecated -- currently still working in 17 mode */
+
 import {
 	initPingEditionsRendering,
 	MessageKind,

apps-rendering/src/components/EmbedWrapper/EmbedWrapper.test.tsx

@@ -2,6 +2,8 @@
  * @jest-environment jsdom
  */
 
+/* eslint-disable react/no-deprecated -- currently still working in 17 mode */
+
 import { matchers } from '@emotion/jest';
 import { EmbedTracksType } from '@guardian/content-api-models/v1/embedTracksType';
 import { none, some } from '../../../vendor/@guardian/types/index';

apps-rendering/src/components/Follow/Follow.test.tsx

@@ -2,6 +2,8 @@
  * @jest-environment jsdom
  */
 
+/* eslint-disable react/no-deprecated -- currently still working in 17 mode */
+
 // ----- Imports ----- //
 
 import { ArticleDesign, ArticleDisplay, ArticlePillar } from '@guardian/libs';

apps-rendering/src/components/PinnedPost/index.tsx

@@ -187,6 +187,8 @@ const PinnedPost: FC<Props> = ({ pinnedPost, format, edition }: Props) => {
 				/>
 			</div>
 			<div id="pinned-post-overlay" css={overlayStyles} />
+			{/* eslint-disable jsx-a11y/label-has-associated-control --
+				i don't know why it's failing, it has htmlFor */}
 			<label
 				css={fakeButtonStyles(format)}
 				htmlFor="pinned-post-checkbox"
@@ -201,6 +203,7 @@ const PinnedPost: FC<Props> = ({ pinnedPost, format, edition }: Props) => {
 					</span>
 				</>
 			</label>
+			{/* eslint-enable jsx-a11y/label-has-associated-control */}
 		</div>
 	);
 };