Skip to content

Commit

Permalink
fix: healthy package.json
Browse files Browse the repository at this point in the history
- all dependencies are development dependencies
- missing peer dependencies are specified
- added list of known issues
  • Loading branch information
mxdvl committed Feb 1, 2023
1 parent 3f662e5 commit cb3a9fc
Show file tree
Hide file tree
Showing 3 changed files with 195 additions and 76 deletions.
77 changes: 74 additions & 3 deletions dotcom-rendering/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"lint-staged": {
"*": "lint"
},
"dependencies": {
"devDependencies": {
"@aws-sdk/client-cloudwatch": "^3.45.0",
"@aws-sdk/client-ssm": "^3.45.0",
"@babel/core": "^7.16.12",
Expand Down Expand Up @@ -137,7 +137,7 @@
"@types/webpack-env": "^1.18.0",
"@types/webpack-node-externals": "^2.5.3",
"@types/youtube": "^0.0.46",
"@typescript-eslint/eslint-plugin": "^5",
"@typescript-eslint/eslint-plugin": "^5.13",
"@typescript-eslint/eslint-plugin-tslint": "^5.20.0",
"@typescript-eslint/parser": "^5",
"ajv": "^8.1.0",
Expand Down Expand Up @@ -204,6 +204,7 @@
"pm2": "5.0.0",
"preact": "^10.5.14",
"preact-render-to-string": "^5.1.19",
"prettier": "^2.4.1",
"prettier-eslint": "^15.0.1",
"pretty-bytes": "^6.0.0",
"react": "^17.0.2",
Expand All @@ -229,7 +230,9 @@
"ts-jest": "^24.3.0",
"ts-loader": "^9.3.0",
"ts-unused-exports": "^8.0.0",
"tslib": "^2.4.0",
"tslib": "^2.4.1",
"tslint": "^6.1.3",
"typescript": "^4.9.3",
"typescript-json-schema": "^0.54.0",
"uuid": "^8.3.2",
"web-vitals": "^2.1.0",
Expand All @@ -248,6 +251,74 @@
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^3.2.3"
},
"known_issues": {
"webpack-filter-warnings-plugin@^1.2.1": {
"webpack": [
"^2.0.0 || ^3.0.0 || ^4.0.0",
"^5.51.1"
]
},
"@guardian/discussion-rendering@^12.0.0": {
"@emotion/react": [
"^11.5.0",
"^11.4.1"
],
"@guardian/libs": [
"^10.0.0",
"^12.0.0"
]
},
"@guardian/eslint-plugin-source-react-components@^10.0.0": {
"@guardian/libs": [
"^9.0.0",
"^12.0.0"
]
},
"@guardian/braze-components@^8.1.3": {
"@guardian/source-react-components-development-kitchen": [
"5.0.0",
"8.2.2"
],
"@guardian/libs": [
"^3.1.0",
"^12.0.0"
]
},
"@guardian/core-web-vitals@^2.0.1": {
"@guardian/libs": [
"^10.0.0",
"^12.0.0"
]
},
"@guardian/atoms-rendering@^25.1.5": {
"@guardian/source-foundations": [
"^8.0.0",
"^7.0.1"
],
"@guardian/source-react-components": [
"^10.0.0",
"^9.1.0"
]
},
"@guardian/[email protected]": {
"@guardian/libs": [
"^9.0.0 || ^10.0.0",
"^12.0.0"
]
},
"@guardian/[email protected]": {
"@guardian/libs": [
"^10.0.0",
"^12.0.0"
]
},
"@guardian/commercial-core@^5.1.3": {
"@guardian/libs": [
"^10.0.0",
"^12.0.0"
]
}
},
"resolutions": {
"@types/serve-static": "^1.13.9"
},
Expand Down
4 changes: 2 additions & 2 deletions dotcom-rendering/scripts/env/check-deps.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
const pkg = require('../../package.json');

if (pkg.devDependencies) {
if (pkg.dependencies) {
const { warn, log } = require('./log');

warn('Don’t use devDependencies');
warn('Don’t use dependencies, devDependencies only!');
log('See https://github.com/guardian/dotcom-rendering/pull/4001');
process.exit(1);
}
Loading

0 comments on commit cb3a9fc

Please sign in to comment.