Skip to content

Commit

Permalink
Fix Playwright tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rupertbates committed Jan 15, 2025
1 parent dd2d999 commit 3f02490
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions dotcom-rendering/playwright/tests/user.features.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ import { addCookie } from '../lib/cookies';
import { loadPageNoOkta } from '../lib/load-page';

test.describe('User cookies tests', () => {
const userAttributesApiUrl =
'https://members-data-api.theguardian.com/user-attributes';
const userBenefitsApiUrl =
'https://user-benefits.code.dev-guardianapis.com';
test(`Request to user features API is sent when no user features expiry cookie`, async ({
context,
page,
Expand All @@ -17,19 +21,19 @@ test.describe('User cookies tests', () => {

await disableCMP(context);

const membersDataApiPromise = page.waitForRequest(
'https://members-data-api.theguardian.com/user-attributes/me',
const userBenefitsApiPromise = page.waitForRequest(
`${userBenefitsApiUrl}/me`,
);

await loadPageNoOkta(page, standardArticle, {
// user-features expects this config to be present
configOverrides: {
userAttributesApiUrl:
'https://members-data-api.theguardian.com/user-attributes',
userAttributesApiUrl,
userBenefitsApiUrl,
},
});

await membersDataApiPromise;
await userBenefitsApiPromise;

// expect GU_U to still be present so it has not been deleted by user-features
expect(
Expand Down Expand Up @@ -64,19 +68,19 @@ test.describe('User cookies tests', () => {

await disableCMP(context);

const membersDataApiPromise = page.waitForRequest(
'https://members-data-api.theguardian.com/user-attributes/me',
const userBenefitsApiPromise = page.waitForRequest(
`${userBenefitsApiUrl}/me`,
);

await loadPageNoOkta(page, standardArticle, {
// user-features expects this config to be present
configOverrides: {
userAttributesApiUrl:
'https://members-data-api.theguardian.com/user-attributes',
userAttributesApiUrl,
userBenefitsApiUrl,
},
});

await membersDataApiPromise;
await userBenefitsApiPromise;
});

test(`Existing old cookie data is deleted when the user is signed out`, async ({
Expand Down

0 comments on commit 3f02490

Please sign in to comment.