Skip to content

Commit

Permalink
fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
marjisound committed Dec 13, 2024
1 parent 953ca7c commit 18a0aa9
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions dotcom-rendering/src/components/Carousel.importable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
import libDebounce from 'lodash.debounce';
import { useEffect, useRef, useState } from 'react';
import { ArticleDesign, type ArticleFormat } from '../lib/articleFormat';
import { getInteractionClient } from '../lib/bridgetApi';
import { formatAttrString } from '../lib/formatAttrString';
import { getSourceImageUrl } from '../lib/getSourceImageUrl_temp_fix';
import { getZIndex } from '../lib/getZIndex';
Expand All @@ -24,6 +25,7 @@ import type {
import type { LeftColSize } from '../types/layout';
import type { MainMedia } from '../types/mainMedia';
import type { OnwardsSource } from '../types/onwards';
import type { RenderingTarget } from '../types/renderingTarget';
import type { TrailType } from '../types/trails';
import { Card } from './Card/Card';
import { LI } from './Card/components/LI';
Expand All @@ -32,8 +34,6 @@ import { ContainerOverrides } from './ContainerOverrides';
import { FormatBoundary } from './FormatBoundary';
import { Hide } from './Hide';
import { LeftColumn } from './LeftColumn';
import { getInteractionClient } from '../lib/bridgetApi';
import { RenderingTarget } from 'src/types/renderingTarget';

type Props = {
heading: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ import { useApi } from '../lib/useApi';
import { addDiscussionIds } from '../lib/useCommentCount';
import { palette } from '../palette';
import type { OnwardsSource } from '../types/onwards';
import type { RenderingTarget } from '../types/renderingTarget';
import type { FETrailType, TrailType } from '../types/trails';
import { Carousel } from './Carousel.importable';
import { Placeholder } from './Placeholder';
import { RenderingTarget } from 'src/types/renderingTarget';

type Props = {
url: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import { useAB } from '../lib/useAB';
import { useIsHorizontalScrollingSupported } from '../lib/useIsHorizontalScrollingSupported';
import { palette } from '../palette';
import type { OnwardsSource } from '../types/onwards';
import type { RenderingTarget } from '../types/renderingTarget';
import type { TagType } from '../types/tag';
import { BigSixOnwardsContent } from './BigSixOnwardsContent';
import { FetchOnwardsData } from './FetchOnwardsData.importable';
import { Section } from './Section';
import { RenderingTarget } from 'src/types/renderingTarget';

type PillarForContainer =
| 'headlines'
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/AudioLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ import { parse } from '../lib/slot-machine-flags';
import type { NavType } from '../model/extract-nav';
import { palette as themePalette } from '../palette';
import type { ArticleDeprecated } from '../types/article';
import type { RenderingTarget } from '../types/renderingTarget';
import { BannerWrapper, Stuck } from './lib/stickiness';
import { RenderingTarget } from '../types/renderingTarget';

const AudioGrid = ({ children }: { children: React.ReactNode }) => (
<div
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/FrontLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
import { AdSlot } from '../components/AdSlot.web';
import { AuEoy2024Wrapper } from '../components/AuEoy2024Wrapper.importable';
import { Carousel } from '../components/Carousel.importable';
import { useConfig } from '../components/ConfigContext';
import { ContainerOverrides } from '../components/ContainerOverrides';
import { CPScottHeader } from '../components/CPScottHeader';
import { DecideContainer } from '../components/DecideContainer';
Expand Down Expand Up @@ -53,7 +54,6 @@ import type {
} from '../types/front';
import { pageSkinContainer } from './lib/pageSkin';
import { BannerWrapper, Stuck } from './lib/stickiness';
import { useConfig } from '../components/ConfigContext';

interface Props {
front: DCRFrontType;
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/NewsletterSignupLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ import { decideTrail } from '../lib/decideTrail';
import { isValidUrl } from '../lib/isValidUrl';
import type { NavType } from '../model/extract-nav';
import type { ArticleDeprecated } from '../types/article';
import type { RenderingTarget } from '../types/renderingTarget';
import { BannerWrapper, Stuck } from './lib/stickiness';
import { RenderingTarget } from '../types/renderingTarget';

type Props = {
article: ArticleDeprecated;
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/lib/useIsBridgetCompatible.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const useIsBridgetCompatible = (
);

useEffect(() => {
hasMinimumBridgetVersion(requiredVersion).then(setIsCompatible);
void hasMinimumBridgetVersion(requiredVersion).then(setIsCompatible);
}, [requiredVersion]);
return isCompatible;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const useIsHorizontalScrollingSupported = (): boolean => {
useEffect(() => {
if (renderingTarget === 'Apps') {
// TODO: update version after new bridget patch is published
hasMinimumBridgetVersion('8.1.0').then(
void hasMinimumBridgetVersion('8.1.0').then(
setHorizontalScrollingSupported,
);
}
Expand Down

0 comments on commit 18a0aa9

Please sign in to comment.