Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable @stylistic plugin in eslint-config #1688

Closed
wants to merge 1 commit into from

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Sep 4, 2024

What are you changing?

Temporarily disabling @stylistic plugin in @guardian/eslint-config

Why?

Installing it alongside @eslint/compat creates a types clash in node_modules.

This unblocks #1668. It will be re-added in a future release.

…onfig

Installing it alongside `@eslint/compat` creates a types
clash in `node_modules`.

It will be re-added in a future release.

eslint/rewrite#104.
@sndrs sndrs requested a review from a team as a code owner September 4, 2024 09:54
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: bbf23e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs self-assigned this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/eslint-config labels Sep 4, 2024
@sndrs
Copy link
Member Author

sndrs commented Sep 4, 2024

resolved by #1689

@sndrs sndrs closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/eslint-config 📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant