Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated typography API #1639

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Aug 9, 2024

What are you changing?

Why?

@sndrs sndrs requested review from a team as code owners August 9, 2024 12:25
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 72ad2e4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Aug 9, 2024
@sndrs sndrs force-pushed the sndrs/remove-old-typogrpahy-API branch from bcfc520 to 238dfd3 Compare August 9, 2024 12:25
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Aug 9, 2024
@sndrs sndrs enabled auto-merge August 12, 2024 08:31
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sndrs sndrs merged commit 70dd3bc into main Aug 12, 2024
21 checks passed
@sndrs sndrs deleted the sndrs/remove-old-typogrpahy-API branch August 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants