Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to pnpm #898

Merged
merged 3 commits into from
Jul 8, 2024
Merged

move to pnpm #898

merged 3 commits into from
Jul 8, 2024

Conversation

vlkerag
Copy link
Contributor

@vlkerag vlkerag commented Jan 19, 2024

What does this change?

move from yarn to pnpm

Why?

pnpm is faster than yarn

Link to Trello

Copy link

changeset-bot bot commented Jan 19, 2024

⚠️ No Changeset found

Latest commit: 087cb21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use corepack which will enable PNPM without requiring consumer to install it directly, and use the packageManager to get a consistent version installed over time.

Here’s some example PRs moving to pnpm:

And an ongoing discussion about moving to PNPM: guardian/csnx#445

@vlkerag vlkerag marked this pull request as ready for review July 2, 2024 14:06
@vlkerag vlkerag requested a review from a team as a code owner July 2, 2024 14:06
Copy link
Contributor

@akinsola-guardian akinsola-guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vlkerag vlkerag merged commit 4bf0656 into main Jul 8, 2024
5 checks passed
@vlkerag vlkerag deleted the pnpm branch July 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants