Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out some unnecessary awaits in module loading code #1771

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

i-hardy
Copy link
Contributor

@i-hardy i-hardy commented Jan 29, 2025

What does this change?

This is a small refactor of unnecesary use of await in module loading/initialisation code.

Why?

This is unlikely to have any significant performance impact, but improves code quality- await should only be used when we actually need to wait for the result of an asynchronous function call in order to proceed with the following code.

@i-hardy i-hardy requested a review from a team as a code owner January 29, 2025 15:10
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: cba0006

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4331ms to load.
For consentless, top-above-nav took on average 3061ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant