Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of Prebid to 8.52.0-11 without hb_ttr targeting #1758

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Jan 21, 2025

What does this change?

Bumps version of @guardian/prebid.js to 8.52.0-11 with hb_ttr removed (see guardian/Prebid.js#166)

Why?

Suspect that this wasn't used since introduction in 2018 (guardian/Prebid.js#4)

This makes the following Prebid upgrade easier

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 58a07c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Ad load time test results

For consented, top-above-nav took on average 4289ms to load.
For consentless, top-above-nav took on average 2806ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@cemms1 cemms1 force-pushed the cemms1/test-remove-hb-ttr-from-prebid branch from 3a6e7a1 to d06fcc8 Compare January 22, 2025 10:04
@cemms1 cemms1 changed the title Test version of prebid without hb_ttr Bump version of Prebid to 8.52.0-11 without hb_ttr targeting Jan 22, 2025
@cemms1 cemms1 marked this pull request as ready for review January 22, 2025 15:59
@cemms1 cemms1 requested a review from a team as a code owner January 22, 2025 15:59
@cemms1 cemms1 merged commit 1a0af2b into main Jan 22, 2025
14 checks passed
@cemms1 cemms1 deleted the cemms1/test-remove-hb-ttr-from-prebid branch January 22, 2025 17:18
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @cemms1 1 minute and 47 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants