Aspect to enforce unique app/region/stack on lambdas #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0aaed07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jakeii
force-pushed
the
jlk/aspect-enforce-unique-app-on-lambdas
branch
from
6cda6ce to
f5ddf8b
Compare
Jakeii
changed the title
akash1810
reviewed
Feb 7, 2025
| ], | ||
| }); | ||
| expect(() => Template.fromStack(stack)).toThrow( | ||
| "GuLambdaFunction must have a unique combination of app, region and stack", |
There was a problem hiding this comment.
The message above also includes "Found duplicate: ${node.app}". Any reason to not capture that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Introduce an
Aspectto enforce unique combinations of app/region/stack onGuLambdaFunction.A few projects at the Guardian seem to be mistakenly doing this, and when used in combination with a generated
riff-raff.yamlcan cause unexpected behaviour where only the last lambda defined will make it into the the deployments as the app/region/stack combination is used for the key.I ran into some circular dependency issues, so had to make some imports more specific in some other modules to resolve.