Conversation
Signed-off-by: mrizzi <mrizzi@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps the reqwest dependency from 0.12 to 0.13 and updates Cargo.lock accordingly, without changing application code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Compliance Guide 🔍(Compliance updated until commit 0119c62)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit 0119c62
|
|||||||||||||||||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
/compliance |
| chrono = "0.4" | ||
| openid = "0.18.0" | ||
| reqwest = { version = "0.12", features = ["json", "blocking"] } | ||
| reqwest = { version = "0.13", features = ["json", "blocking"] } |
There was a problem hiding this comment.
Suggestion: Revert dependency update due to unhandled breaking changes
| reqwest = { version = "0.13", features = ["json", "blocking"] } | |
| reqwest = { version = "0.12", features = ["json", "blocking"] } |
There was a problem hiding this comment.
Can you point me to the problematic call.
There was a problem hiding this comment.
Ask❓
Can you point me to the problematic call.
Answer:
Based on the PR diff you shared, there isn’t any call-site change to review—this PR only bumps the dependency line in Cargo.toml. So I can’t “point to the problematic call” from the diff itself because no reqwest usage sites are shown here, and the bot comment doesn’t reference a конкрет compile error or file/line.
The quickest way to identify the real problematic call is to look at the compiler/CI output after the bump:
- Run:
cargo check -q(or your full CI build)
- Find the first error mentioning
reqwest(it will include the file path + line/column). - That file/line is the “problematic call” you’re looking for.
If you want to locate candidates before running CI, search for reqwest usage:
rg "reqwest::|use reqwest|ClientBuilder|RequestBuilder|blocking::" -n
Then focus on any usage of reqwest::blocking::* (since you have the blocking feature enabled), and any less-common APIs like multipart, Proxy, or tls/client builder settings, which are the most likely to have signature/feature changes across minor-major bumps.
If you paste the exact build error (the first error[E...] mentioning reqwest) or point me to the file/line, I can tell you exactly which call needs updating and what the new 0.13-compatible replacement should be.
There was a problem hiding this comment.
@qodo-code-review Can you point me to the problematic call.
There was a problem hiding this comment.
Ask❓
@qodo-code-review Can you point me to the problematic call.
Answer:
I can’t point to a specific “problematic call” from the PR diff you shared, because the diff only changes the dependency version in Cargo.toml and does not include any reqwest call sites (no Rust source changes / no compiler error context).
To find the exact call that breaks with reqwest = 0.13, you’ll need to use the build output (it will contain the file + line/column):
- Run (or check CI logs):
cargo check(orcargo test)
- Find the first error mentioning
reqwest/hyper/http- it will look like
error[E...] ... --> path/to/file.rs:LINE:COL
- it will look like
- That
file.rs:LINEis the “problematic call”.
If you want to proactively locate likely hotspots before running CI, grep for usage sites:
rg -n "reqwest::|use reqwest|ClientBuilder|RequestBuilder|blocking::" .
Given you enable blocking, start with any reqwest::blocking::* usage first—those are often where signature/type changes surface across reqwest upgrades.
If you paste the first compiler error that mentions reqwest (including the file/line), I can tell you exactly which call needs updating and what the 0.13-compatible replacement is.
Refers to https://issues.redhat.com/browse/TC-3442 (for testing)
Summary by Sourcery
Build: