Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing functions to MessageDialog #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iK4tsu
Copy link

@iK4tsu iK4tsu commented Jun 17, 2020

Signed-off-by: João Lourenço [email protected]

@ljmf00
Copy link

ljmf00 commented Jun 18, 2020

I would say it's better to put the function inside this file, here: https://github.com/gtkd-developers/GtkD/blob/master/src/APILookupGtk.txt#L2007

by adding:

noCode: format_secondary_text
noCode: format_secondary_markup

and the actual code inside this scope:

code: start
// ...
code: end

Anyway, I don't see any of these as a good approach since it should be generated from the bindings. Could you give a hint here @MikeWey ?

@MikeWey
Copy link
Member

MikeWey commented Jun 18, 2020

Adding them via the Lookup files is indeed better, since than the additions will survive when regenerating the binding.

The aren't generated because we currently don't have a good way to get the variatic parameter across the binding without human intervention. Although dlangs meta programming may have improved enough to get it working.

@iK4tsu
Copy link
Author

iK4tsu commented Jun 18, 2020

Sorry I'm new to this project. I noticed those files before making the PR, but found it strange when some functions were missing, setMarkup and the deprecated getImage and setImage. Because of that I decided to add them directly on the class itself. Maybe I should've just made an issue instead. Since the PR I've been trying to figure out how to generate those bindings with the Lookup file, unsuccessfully.

Should I amend my PR and add these changes in the Lookup file? And how can I test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants