Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hex escapes instead of octal to satisfy overzealous linters #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevvvn
Copy link

@stevvvn stevvvn commented Jul 10, 2018

I ran into this issue trying to bundle an app with nexe:

Acorn error: Octal literal in strict mode (3:13)
File: /home/git/hub-service-node/node_modules/qrcode-terminal/lib/main.js

1 var QRCode = require('./../vendor/QRCode'),
2 QRErrorCorrectLevel = require('./../vendor/QRCode/QRErrorCorrectLevel'),
3 black = "\033[40m \033[0m",

I think the diagnostic is wrong as this code shouldn't be evaluated by strict standards, but oct->hex seems like an easy enough compromise to convince it to include the file in the bundle.

@stevvvn
Copy link
Author

stevvvn commented Jul 10, 2018

CI failure seems out of my control

@ramphy
Copy link

ramphy commented Jun 1, 2023

This is a necessary update! Thank you!

@AlexV525
Copy link

@gtanner Can we get this resolved?

@chybisov
Copy link

chybisov commented Dec 8, 2023

@mwbrooks @gtanner please merge and release this fix. We have issues using qrcode-terminal with Next.js 14 because of this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants