Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern proposal for exposing client TLS cert in server-side call context in gRPC-JS #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidfiala
Copy link

Modern proposal for exposing client TLS cert in server-side call context. Discussion on grpc/grpc-node#2730 suggested we start here.

Modern proposal for exposing client TLS cert in server-side call context. Discussion on grpc/grpc-node#2730 suggested we start here.
@murgatroid99
Copy link
Member

When I talked about editing this proposal, I was thinking about an addendum that would expand the sslPeerCertificate field in the grpc-js implementation. It's not appropriate to edit an existing proposal to propose a complete different API and implementation. Instead it would be better to have a new proposal for a change this substantial. Then after that we could edit this proposal to indicate that it has been superseded by the new one.

@davidfiala
Copy link
Author

Apologies. I see the documentation in the repos. I'll revise the PR and correctly create a new proposal. Thanks for the note.

If anyone is interested in a strawman code-based proposal in the meanwhile, I've drafted what such a change could potentially look like here: davidfiala/grpc-node@570fa81

I'd appreciate any early feedback to help ensure that we're closer to an ergonomic, agreed-upon doc! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants