GCP CSM Observability Java client use XdsCredentials #11505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument and use XdsCredentials if passed.
ejona86
reviewed
Sep 9, 2024
| if (args.length > 0) { | ||
| if ("--help".equals(args[0])) { | ||
| System.err.println("Usage: [name [target [prometheusPort]]]"); | ||
| System.err.println("Usage: [--xds-creds [name [target [prometheusPort]]]]"); |
There was a problem hiding this comment.
Since xdscreds is separately optional, it should be [--xds-creds] [name [target...
gcp CSM Observability examples are already in gRPC.io docker hub. I just tried avoiding creating and maintaining another set of docker images without exposing metrics on a Prometheus port. In the user guide we pull the example code from docker. |
|
Also the Proxyless service-mesh guide already uses the CSM Observability example as well: https://cloud.google.com/service-mesh/docs/gateway/proxyless-grpc-mesh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To demonstrate using the CSM mesh client to talk to cloud run services in user guide, introduce a command line option to use XdsCredentials.