On result2 resolution result have addresses or error #11330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the acceptance of the name resolution by the load balancer.
…the acceptance of the name resolution by the load balancer.
…dressesOrError' into onResult2_resolutionResultHaveAddressesOrError # Conflicts: # api/src/main/java/io/grpc/NameResolver.java # core/src/test/java/io/grpc/internal/DnsNameResolverTest.java # netty/src/test/java/io/grpc/netty/UdsNameResolverTest.java
|
I synced and resolved conflicts from the website, and ended up with some compilation errors. Will pull changes to my cloudtop, fix them and upload the changes. |
…ro android build there is a warning and it seems to get treated as an error because of my change and cause failure.
…ed with a timeout.
|
Let's discuss this in the next API review meeting. |
sergiitk
reviewed
Aug 6, 2024
Co-authored-by: Sergii Tkachenko <[email protected]>
Implemented changes discussed:
|
…alStateException if there is no value set.
…dressesOrError' into onResult2_resolutionResultHaveAddressesOrError
|
ejona86
approved these changes
Oct 3, 2024
…dressesOrError' into onResult2_resolutionResultHaveAddressesOrError
|
Code coverage check was failing including for some of the existing lines that I touched that previously didn't have coverage. Fixed all code coverage errors. PTAL @ejona86 . |
ejona86
reviewed
Oct 4, 2024
ejona86
approved these changes
Oct 4, 2024
kannanjgithub
added a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
Combined success / error status passed via ResolutionResult to the NameResolver.Listener2 interface's onResult2 method - Addresses in the success case or address resolution error in the failure case now get set in ResolutionResult::addressesOrError by the internal name resolvers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for passing the error status via ResolutionResult, and enhancing the ResolutionResult for the same. This PR is branched from the branch used for #11313 that introduced onResult2 returning the Status.