Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation tags to opencensus metrics #11322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stanley-cheung
Copy link
Contributor

Add two tags to the A66 metrics exported by the opencensus stats module. This will be picked up by the Cloud Monitoring pipeline and allow us to build dashboard off these tags.

Similarly done in grpc-ecosystem/grpc-spring#1081

Add two tags to the A66 metrics exported by the opencensus stats module. This will be picked up by the Cloud Monitoring pipeline and allow us to build dashboard off these tags.

Similarly done in grpc-ecosystem/grpc-spring#1081
@stanley-cheung
Copy link
Contributor Author

cc @fengli79 @DNVindhya

@ejona86
Copy link
Member

ejona86 commented Jul 2, 2024

Where are these tags defined? Where's the design?

@stanley-cheung
Copy link
Contributor Author

Where are these tags defined? Where's the design?

Responded in DM

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait until the spec changes are done before merging this.

@@ -787,6 +799,8 @@ public ServerStreamTracer newServerStreamTracer(String fullMethodName, Metadata
tagger
.toBuilder(parentCtx)
.putLocal(RpcMeasureConstants.GRPC_SERVER_METHOD, methodTag)
.putLocal(INSTRUMENTATION_SOURCE, LIBRARY_NAME)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the looks of it, we should just do something like this on client-side as well and not update the individual record sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants