.*: replace grpc.Dial with grpc.NewClient in test files
#7609
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7609 +/- ##
==========================================
- Coverage 81.73% 81.70% -0.03%
==========================================
Files 361 361
Lines 27817 27817
==========================================
- Hits 22735 22729 -6
- Misses 3871 3877 +6
Partials 1211 1211 |
purnesh42H
added
Area: Client
purnesh42H
changed the title
grpc.Dial with grpc.NewClient in test files
|
@hanut19 please complete your CLA Authorization. Also, please ensure following the convention for PR description and title for next PRs |
| if err != nil { | ||
| t.Fatalf("failed to dial local test server: %v", err) | ||
| t.Fatalf("failed to NewClient() local test server: %v", err) |
There was a problem hiding this comment.
failed to create new client for local test server. Please apply this everywhere
hanut19
force-pushed
the
replace-dial-with-newclient-in-balancer
branch
from
fa6d247
to
2344f90
Compare
|
@dfawley for second review |
|
Note that the CLAs are currently broken, so we can't merge this. |
| if err != nil { | ||
| log.Fatalf("Failed to dial: %v", err) | ||
| log.Fatalf("Failed to NewClient: %v", err) |
There was a problem hiding this comment.
"dial" is a verb. "NewClient" is not. Please fix the errors that don't have proper grammar.
There was a problem hiding this comment.
@hanut19 failed to create new client. Similar to what you changed elsewhere. I think you missed this one
|
another PR is raised #7640 |
Partially address: #7049
Update tests where only direct replacement is enough to replace
grpc.Dialwithgrpc.NewClientin test filesRELEASE NOTES: None