clusterimpl: use gsb.UpdateClientConnState instead of switchTo, on receipt of config update #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7567 +/- ##
=========================================
Coverage ? 81.73%
=========================================
Files ? 361
Lines ? 27818
Branches ? 0
=========================================
Hits ? 22738
Misses ? 3871
Partials ? 1209
|
aranjans
force-pushed
the
stop_using_switchTo_clusterimpl
branch
2 times, most recently
from
6b07deb
to
0f5b421
Compare
aranjans
force-pushed
the
stop_using_switchTo_clusterimpl
branch
5 times, most recently
from
0c2482c
to
51d0d75
Compare
easwars
reviewed
Sep 4, 2024
aranjans
force-pushed
the
stop_using_switchTo_clusterimpl
branch
from
943294d
to
07b3fd9
Compare
easwars
reviewed
Sep 5, 2024
easwars
approved these changes
Sep 9, 2024
easwars
reviewed
Sep 9, 2024
purnesh42H
reviewed
Sep 10, 2024
purnesh42H
reviewed
Sep 10, 2024
purnesh42H
approved these changes
Sep 10, 2024
aranjans
force-pushed
the
stop_using_switchTo_clusterimpl
branch
from
842c3d8
to
60a5a8e
Compare
aranjans
force-pushed
the
stop_using_switchTo_clusterimpl
branch
from
caf1f0a
to
da66a18
Compare
|
@aranjans : Could you please handle any open comments here. Thanks. |
easwars
reviewed
Sep 18, 2024
Comment on lines
245
to
253
| // Build config for the gracefulswitch balancer. It is safe to ignore JSON | ||
| // marshaling errors here, since the config was already validated as part of | ||
| // ParseConfig(). | ||
| cfg := []map[string]any{{newConfig.ChildPolicy.Name: newConfig.ChildPolicy.Config}} | ||
| cfgJSON, _ := json.Marshal(cfg) | ||
| parsedCfg, err := gracefulswitch.ParseConfig(cfgJSON) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Hmm... actually what is the reason for moving this block to be done after handling telemetry labels and drop/request counts?
There was a problem hiding this comment.
Ah, imo it won't matter when are we building the chilld config for gracefulswitch balancer. Does it?
Anyways, I have reverted that and updated the PR.
There was a problem hiding this comment.
Generally, it is a good idea to not make a change without a need for it.
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Oct 1, 2024
…ceipt of config update (grpc#7567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7210 talks about not using deprecated APIs in the
gracefulswitch.Balancerwhile switching the child policy on reciept of configuration update of clusterimpl. This PR makes the required changes for the same.RELEASE NOTES:
gsb.UpdateClientConnStateinstead ofswitchTo, on receipt of config update