transport/grpchttp2: add http2.Framer bridge #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7453 +/- ##
==========================================
+ Coverage 81.41% 81.67% +0.26%
==========================================
Files 357 359 +2
Lines 27261 27515 +254
==========================================
+ Hits 22195 22474 +279
+ Misses 3843 3817 -26
- Partials 1223 1224 +1
|
printchard
changed the title
printchard
changed the title
printchard
force-pushed
the
framer-adapter
branch
from
d8f309d
to
f43d3b9
Compare
easwars
requested changes
Jul 31, 2024
printchard
commented
Jul 31, 2024
easwars
reviewed
Aug 2, 2024
|
Feels like we are very close to the finish line on this PR. |
arvindbr8
requested changes
Aug 8, 2024
easwars
approved these changes
Aug 13, 2024
| }, nil | ||
| default: | ||
| buf := fr.pool.Get(int(hdr.Size)) | ||
| huf := f.(*http2.UnknownFrame) |
There was a problem hiding this comment.
Just curious, what's a huf? lol
There was a problem hiding this comment.
I meant to type uf lol.
| return uint16(b[0])<<8 | uint16(b[1]) | ||
| } | ||
|
|
||
| // checkWrittenHeader takes a byte buffer representing a written frame header |
There was a problem hiding this comment.
The function name has changed. Needs fixing here.
There was a problem hiding this comment.
Changed the actual description but forgot the name 😅. It is done now.
infovivek2020
pushed a commit
to infovivek2020/grpc-go
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create HTTP2Bridge on the grpchttp2 package.
As part of the ongoing effort to migrate into a new Framer inside the grpchttp2 package, I added an adapter for the http2.Framer implementation to provide a way to opt-out of the new feature.
RELEASE NOTES: none