Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiling with ARC and non-ARC #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zman0900
Copy link
Contributor

@zman0900 zman0900 commented May 4, 2012

Using the method described at http://mobile.dzone.com/articles/arc-support-without-branching I modified the code so it will compile for ARC projects while still being compatible with non-ARC projects.

@grp
Copy link
Owner

grp commented May 5, 2012

Looks good; nice recognition of the... "unique" memory management used in here.

Only question is if ARCMacros.h is necessary. Maybe it'd be better to move those (and possibly rename them with a PtR related prefix) into the main header, to be sure it doesn't conflict?

@zman0900
Copy link
Contributor Author

The contents of that file were taken unmodified from another site, so that's why I left them in their own file. The file could just be prefixed with PullToRefresh to avoid having to move its contents...

Edit: I made the changed and committed to the same topic branch, but it is not showing up here.

@grp
Copy link
Owner

grp commented Jul 9, 2012

I would prefer they weren't here at all — I think they're reasonably unnecessary for a tiny project this size. Honestly, I'm not 100% sure why this is needed at all: with a few changes to the header, PullToRefreshView should be fine in both ARC and non-ARC projects, since you can have both types of code in one project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants