Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Microsoft Edge Chromium, fix Chrome driver download #445

Open
wants to merge 8 commits into
base: 2.x
Choose a base branch
from

Conversation

rhpijnacker
Copy link

This pull request is a combination of:

  • Fixing the Chrome driver discovery and download
  • Support for the Microsoft Edge Chromium browser (removing Edge HTML support)

Unfortunately, I cannot get it compiled with xuggle, so I had to disable video capture, any help with this would be appreciated.

I added a new downloadable release for public use.

@damencho
Copy link

@rhpijnacker About the huggle I had replaced it #410
And then I had completely removed it and used ffmpeg intead #412 also some memory leaks fixes in the same area #411 ...

@rrapier
Copy link

rrapier commented Jul 13, 2022

Can this be merged? I'm looking to use edge chromium and i cannot do it in the 2.0.4 snapshot version. @damencho @rhpijnacker

@rhpijnacker
Copy link
Author

@rrapier
Copy link

rrapier commented Jul 20, 2022

I grabbed the release version and started it up.
i am getting the following on execution:
[INFO ] 2022-07-20 09:30:15 Log - Started with Driver Creation
error 20-Jul-2022 09:30:15 org.openqa.selenium.WebDriverException: Error forwarding the new session cannot find : Capabilities {browserName: edge, deviceType: Web, platformName: windows, report.customFields: Build=Release,ReleaseName=0..., securityToken: eyJhbGciOiJIUzI1NiIsInR5cCI..., takesScreenshot: true, user: [email protected]}

I noticed it downloaded msedgedriver version 75. Edge latest is 103. Why is it not grabbing latest version of edge driver?

@rhpijnacker
Copy link
Author

I think it downloads the version that you have specified in the node_5555.json file.
Could it be it is configured for version 75 there?

You could try removing all json files and running the initial configuration again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants