Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixing/fix safari edge max instancesto1 #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarwaOuledElHadjAli
Copy link

Safari and Edge maxInstances should be equals to 1

Safari MaxInstances should be 1
Edge MaxInstances should be 1
@glacier6327
Copy link

@MarwaOuledElHadjAli are you able to use this project? Our group used it a few years ago and we loved it, but I see no code changes in almost two years... Also : @dimacus @smccarthy

@byamagata
Copy link

@glacier6327 I can confirm that my company still uses this project. It has its issues, but we make up for it with proprietary software that helps with cleanup, management, etc. Basically I have written a wrapper around it that makes sure things are taken care of. Why do you ask?

@chamiz
Copy link

chamiz commented Feb 3, 2021

@MarwaOuledElHadjAli What is the reason for setting maximum instances to 1? Is this change applicable for old Edge or Edge Chromium?

@MarwaOuledElHadjAli
Copy link
Author

@MarwaOuledElHadjAli What is the reason for setting maximum instances to 1? Is this change applicable for old Edge or Edge Chromium?

If instances are more than 1 ==> test fails

@chamiz
Copy link

chamiz commented Feb 3, 2021

Oh. Thanks for the tip. This for Edge legacy right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants