Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-hosted: document the importance of GRIST_DEFAULT_EMAIL #448

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Nov 25, 2024

I need to reference this value from another PR

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit 585e46b
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/6746187e40196200088ebb8c
😎 Deploy Preview https://deploy-preview-448--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulfitz
Copy link
Member

An extra gotcha that often trips people up is ownership of the team site created on first run if GRIST_SINGLE_ORG is set
https://github.com/gristlabs/grist-core/blob/1f984ab5a7338430ab98cba42cb0d7b0daa229bc/stubs/app/server/server.ts#L63-L90
The owner will be GRIST_DEFAULT_EMAIL so things get very confusing if that email is changed but the team site is kept (and is now inaccessible!)

@jordigh jordigh force-pushed the jordigh/default-email branch from f50cbaa to d4a2753 Compare November 25, 2024 22:31
@jordigh
Copy link
Contributor Author

jordigh commented Nov 25, 2024

I added a comment about this. Does that help?

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jordi! One more note.

configured by `GRIST_DEFAULT_EMAIL`. If you change the value of
`GRIST_DEFAULT_EMAIL`, [the
administrator](self-managed.md#what-is-the-administrative-account) may
temporarily lose access to the team site.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a little more precise.

If GRIST_SINGLE_ORG is set, then on start-up Grist will create the specified team site if isn't already present. When creating it, it will make the current administrator an owner of it. Before changing the administrator, it is a good idea to use team sharing options to add new owners to the team site, since apart from initial creation, administrators have no automatic right to team site membership.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added your note. Does that look better?

@jordigh jordigh force-pushed the jordigh/default-email branch from d4a2753 to ad14b6b Compare November 26, 2024 18:24
@jordigh jordigh force-pushed the jordigh/default-email branch from ad14b6b to 585e46b Compare November 26, 2024 18:50
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jordigh

@jordigh jordigh merged commit accaeac into master Nov 26, 2024
5 checks passed
@jordigh jordigh deleted the jordigh/default-email branch November 26, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants