Enabling BiDi mode - fixing test failures #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berhalak
force-pushed
the
enable-bidi-mode
branch
from
880eaa5 to
bd4316b
Compare
|
That seems good to me, and the tests passes! FWIW, I have cherry-picked your commit to see if that also fixes the CI for my PR #1149 |
jordigh
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Latest chrome version 127, has started ignoring alerts and popups when controlled via a webdriver.
SeleniumHQ/selenium#14290
Proposed solution
According to the article above, popups and alerts are still shown in
BiDisessions. While we don't have latest webdriver library (where the newenableBiDimethod is exposed), it can be toggled by using thesetmethod incapabilitiesinterface, as it is done here https://github.com/shs96c/selenium/blob/ff82c4af6a493321d9eaec6ba8fa8589e4aa824d/javascript/node/selenium-webdriver/firefox.js#L415Has this been tested?