Skip to content

Conversation

@RMeli
Copy link
Contributor

@RMeli RMeli commented Mar 3, 2025

CMake's FindBLAS.cmake/FindLAPACK.cmake do not support NVPL. This PR adds support for NVPL BLAS and NVPL LAPACK to the CMake build system.

@awvwgk
Copy link
Member

awvwgk commented Mar 3, 2025

Could you share a reference for NVPL?

@RMeli
Copy link
Contributor Author

RMeli commented Mar 3, 2025

The landing page is the following: NVPL

Library-specific documentation is the following:

CMake support is still in its infancy, but I used the same naming conventions.

@marvinfriede marvinfriede merged commit 1e2069a into grimme-lab:main Mar 12, 2025
7 checks passed
@RMeli RMeli deleted the nvpl branch March 12, 2025 15:45
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.65%. Comparing base (282626e) to head (c27d382).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   51.57%   51.65%   +0.07%     
==========================================
  Files          18       18              
  Lines        1648     1663      +15     
  Branches      746      752       +6     
==========================================
+ Hits          850      859       +9     
  Misses        390      390              
- Partials      408      414       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants