Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dynamic stylesheet and migrated to CSS vars #2854

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Removed dynamic stylesheet and migrated to CSS vars #2854

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bfa84fa
- Removed dynamic stylesheet and migrated to CSS vars
lmartorella Nov 14, 2024
cf62b1d
- Fixed flickering during resize
lmartorella Nov 14, 2024
bf7a96a
- Fixed placeholder not moving vertically
lmartorella Nov 14, 2024
aab0fb2
- Merged SCSS definitions
lmartorella Nov 15, 2024
9cb7ef5
- Tied CSS vars to gridstack element rather than the parent
lmartorella Nov 15, 2024
db2615e
- Removed unused code
lmartorella Nov 15, 2024
6bad283
- Reverted `n` renamed to `node`
lmartorella Nov 15, 2024
b5624d9
- Separated drag/resize
lmartorella Nov 15, 2024
60c75bb
- Removed obsolete tests
lmartorella Nov 15, 2024
9b013fa
- Linted
lmartorella Nov 15, 2024
57d75a3
- Less rule in case of 1x1 elements
lmartorella Nov 15, 2024
d618ef5
- Linted
lmartorella Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/gridstack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,12 @@ export class GridStack {
if ((!n._moving && !n._resizing) || this._placeholder === el) {
// Set inline style, refer CSS variables
lmartorella marked this conversation as resolved.
Show resolved Hide resolved
el.style.top = `calc(${n.y} * var(--gs-cell-height))`;
el.style.height = `calc(${n.h} * var(--gs-cell-height))`;
if (n.h !== 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.h > 1 ? el.style.height = calc(${n.h} * var(--gs-cell-height)) : delete el.style.height; // default h=1 set globally

to match above case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger the

Extract the assignment of "el.style.height" from this expression.sonarlint(typescript:S1121)

sonar lint issue, part of the recommended TS set.
I quite agree to that, being a "delete" part of else branch as well.
A better way is probably trying to assign an empty string to height, or undefined.

el.style.height = `calc(${n.h} * var(--gs-cell-height))`;
} else {
// height is set to --gs-cell-height by default
delete el.style.height;
}
}
return this;
}
Expand Down