ci: minor polish, add codespell action, add clang permutation #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v2:
|
gregkh
requested changes
Oct 16, 2024
lsusb.c
Outdated
| static const char * const encryption_type[] = { | ||
| "UNSECURE", | ||
| static const char *const encryption_type[] = { | ||
| // clang-format off |
There was a problem hiding this comment.
That's not ok, sorry, if clang-format can't handle this, then don't use it.
It also doesn't have much to do with the codespell changes.
There was a problem hiding this comment.
Don't throw the baby out with the bathwater idiom comes to mind. No tool is perfect and the odd comment beats the very inconsistent code-base IMHO.
That said, I've dropped the ^^ hunk.
|
I took all but the first commit here. Can you split that up please? |
Make the code a bit more clean and consistent. Signed-off-by: Emil Velikov <[email protected]>
That's our defined style and that we've been using in the majority of the codebase. Disable clang-format on a couple of sections, where it gets a silly moment and insists on reformatting everything. Signed-off-by: Emil Velikov <[email protected]>
v2: - ignore NEWS, omit suppressions - split off style changes Signed-off-by: Emil Velikov <[email protected]>
gregkh
approved these changes
Oct 16, 2024
gregkh
approved these changes
Oct 16, 2024
gregkh
approved these changes
Oct 16, 2024
gregkh
approved these changes
Oct 16, 2024
|
Looks good, thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a couple of minor ci bits and adds a few more actions.
Everything is run in parallel, so as far as turn around times are concerned there's no overhead.
While adding the codespell action, I've went through the whole repo and fixed a few issues. Although I'm not sure if we want the "UNSECURE" -> "INSECURE" one.
As a follow-up, I could update the existing run to use sanitizers so we get undefined behaviour, leaks, etc all flagged up as they appear... Assuming there is interest of course.