Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature Comparison Analysis (Part II) #59

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Add Feature Comparison Analysis (Part II) #59

merged 1 commit into from
Oct 6, 2017

Conversation

gwaybio
Copy link
Collaborator

@gwaybio gwaybio commented Oct 5, 2017

Adding all intermediate results for the ./nf1_feature_comparison.sh analysis. These are uploaded following the updates to #58

@gwaybio gwaybio requested a review from dhimmel October 5, 2017 20:21
dhimmel
dhimmel reviewed Oct 5, 2017
View reviewed changes
Copy link

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The row names, for example in feature_comparison/NF1/adage/classifier_coefficients.tsv seem likely to cause confusion or breakage, with no value to including them?

@gwaybio gwaybio mentioned this pull request Oct 6, 2017
Open
@gwaybio
Copy link
Collaborator Author

gwaybio commented Oct 6, 2017

The row names, for example in feature_comparison/NF1/adage/classifier_coefficients.tsv seem likely to cause confusion or breakage, with no value to including them?

I agree - this has caused issues in the past as well. I filed issue greenelab/tybalt#86 and will address it in a later PR.

@gwaybio gwaybio merged commit 7c398f8 into greenelab:master Oct 6, 2017
@gwaybio gwaybio deleted the add-comparison-intermediate branch October 6, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhimmel dhimmel dhimmel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwaybio @dhimmel