Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Highcharts plugin): fix inner var name TOOLTIP_ROW_NAME_CLASS_NANE -> TOOLTIP_ROW_NAME_CLASS_NAME #553

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(Highcharts plugin): fix inner var name TOOLTIP_ROW_NAME_CLASS_NANE -> TOOLTIP_ROW_NAME_CLASS_NAME #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/highcharts/renderer/helpers/config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import formatTooltip, {
TOOLTIP_HEADER_CLASS_NAME,
TOOLTIP_LIST_CLASS_NAME,
TOOLTIP_ROW_CLASS_NAME,
TOOLTIP_ROW_NAME_CLASS_NANE,
TOOLTIP_ROW_NAME_CLASS_NAME,
} from '../tooltip';

import {handleLegendItemClick} from './handleLegendItemClick';
Expand Down Expand Up @@ -176,7 +176,7 @@ export function synchronizeTooltipTablesCellsWidth(tooltipContainer, isMobile) {
}

if (isMobile && tooltipOverflowsViewport) {
const rowNamesNodes = tooltipContainer.querySelectorAll(`.${TOOLTIP_ROW_NAME_CLASS_NANE}`);
const rowNamesNodes = tooltipContainer.querySelectorAll(`.${TOOLTIP_ROW_NAME_CLASS_NAME}`);

for (let i = 0; i < rowNamesNodes.length; i++) {
const node = rowNamesNodes[i];
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/highcharts/renderer/helpers/highcharts/highcharts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
TOOLTIP_FOOTER_CLASS_NAME,
TOOLTIP_LIST_CLASS_NAME,
TOOLTIP_ROW_CLASS_NAME,
TOOLTIP_ROW_NAME_CLASS_NANE,
TOOLTIP_ROW_NAME_CLASS_NAME,
} from '../tooltip';

import colors from './colors';
Expand Down Expand Up @@ -334,7 +334,7 @@ function initHighcharts({isMobile}) {
}

if (isFixation) {
const rowNames = this.container.querySelectorAll(`.${TOOLTIP_ROW_NAME_CLASS_NANE}`);
const rowNames = this.container.querySelectorAll(`.${TOOLTIP_ROW_NAME_CLASS_NAME}`);

for (let i = 0; i < rowNames.length; i++) {
const rowNameNode = rowNames[i];
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/yagr/renderer/tooltip/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import './tooltip.scss';
const SERIES_NAME_DATA_ATTRIBUTE = 'data-series-name';
const SERIES_IDX_DATA_ATTRIBUTE = 'data-series-idx';
const TOOLTIP_CONTAINER_CLASS_NAME = '_tooltip';
const TOOLTIP_ROW_NAME_CLASS_NANE = '_tooltip-rows__name-td';
const TOOLTIP_ROW_NAME_CLASS_NAME = '_tooltip-rows__name-td';
const TOOLTIP_ROW_CLASS_NAME = '_tooltip-row';
const TOOLTIP_HEADER_CLASS_NAME = '_tooltip-header';
const TOOLTIP_LIST_CLASS_NAME = '_tooltip-list';
Expand All @@ -24,7 +24,7 @@ const renderColorCell = (line: TooltipLine) =>
</td>`;

const renderNameCell = (line: TooltipLine) =>
`<td class="${TOOLTIP_ROW_NAME_CLASS_NANE}">
`<td class="${TOOLTIP_ROW_NAME_CLASS_NAME}">
${line.hideSeriesName ? '' : escapeHTML(line.seriesName)}
</td>`;

Expand Down
Loading