Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor column detection #62

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

niktverd
Copy link
Contributor

@niktverd niktverd commented Jun 7, 2023

No description provided.

@niktverd niktverd requested a review from NikitaCG as a code owner June 7, 2023 09:16
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@NikitaCG NikitaCG requested a review from gorgeousvlad June 9, 2023 09:54

return blocks;
},
{} as Record<string, unknown>,
Copy link
Collaborator

@NikitaCG NikitaCG Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we can use React.FC<> instead unknown in this type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@NikitaCG
Copy link
Collaborator

NikitaCG commented Jun 9, 2023

@gorgeousvlad we need your look)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants