introduces mapSchemaConfig utility function #4297
Open
+919
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
map
branch
2 times, most recently
from
e747264
to
23e7952
Compare
yaacovCR
changed the title
|
note: diff is easier to scan when hiding whitespace |
yaacovCR
changed the title
extracting this from lexicographicallySortSchema and extendSchemaImpl motivation: 1. to use to further enhance extendSchema/buildASTSchema/buildSchema to take resolvers, etc, and 2. to expose a generic safe mapSchemaConfig
|
This re-implementation brings a 24% performance boost to
I'm not sure yet what exactly brings the performance boost, I was just hoping for parity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation:
TO DO: improve test coverage