-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for graphql-core 3 to graphql_ws.aiohttp #43
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: oleg.hoefling <[email protected]>
…uring on travis, add test dependencies to requirements_dev.txt, add status badges to readme Signed-off-by: oleg.hoefling <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage ? 35.58%
=========================================
Files ? 8
Lines ? 489
Branches ? 54
=========================================
Hits ? 174
Misses ? 303
Partials ? 12 Continue to review full report at Codecov.
|
Signed-off-by: oleg.hoefling <[email protected]>
Thank for sharing , it's really appreciated. |
error_type, | ||
error_payload | ||
) | ||
return self.send_message(connection_context, op_id, error_type, error_payload) | ||
|
||
def unsubscribe(self, connection_context, op_id): | ||
if connection_context.has_operation(op_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the connection_context.get_operation(op_id).dispose()
seems to depend on the old rxpy
-dependency that has been removed from graphql-core
and is effectively removed in this branch by removing setup_observable_extension
.
this causes an unhandled exception on unsubscribe
@hoefling do you have any plans to update this PR? The wider ecosystem seems to be adopting graphql-core 3 and the version constraint here is bound to start generating issues. I'm experiencing issues in the examples for https://github.com/torchbox/wagtail-grapple since we've updated to django-graphene >= 3. |
@dopry let me take a look at it, it's been a while now :-) |
Any objections against just integrating this into GQL-Server? Websocket-Based Subscriptions have become a common pattern in GQL and an integration would reduce the amount of duplicate code and management effort. |
Signed-off-by: oleg.hoefling [email protected]
This PR adds support for
graphql-core>=3
tographql.aiohttp.AiohttpSubscriptionServer
. Note that this will break the rest of theBaseSubscriptionServer
implementations! Unfortunately, I am not familiar with Sanic orgevent
to adapt those too.This PR violates against the PR submission rule
as
graphql-core>=3
is compatible with Python 3.6 onwards. Also, all of the Python versions listed have reached EOL anyway (except Python 3.5 which will reach EOL in September).